On Sat, 7 Jul 2012, Greg Kroah-Hartman wrote: > > >Minor cleanup in the future, can't this be merged with snoop_urb() that > > >way you don't have to do the logic checking in the places you call this > > >function instead of snoop_urb()? That would make it a bit simpler for > > >the "normal" code path, right? > > > > Alan already made the same remark :) The problem is that snoop_urb is > > also used for logging the synchronous urb ioctls, where there is no urb. > > So making snoop_urb generic would require it gaining a struct urb * > > argument while keeping its unsigned char *data and int data_len > > arguments, and add an if (urb) ... else in there, so this way seems > > better. > > Ok, fair enough. If I get annoyed I'll go see if I can figure out how > to simplify it later, as I think I'm the only one that uses it :) > > Actually, I'll probably just move it to use the tracepoint > infrastructure, as that's the proper thing to do in the end. Or we can get rid of the usbfs URB snooping entirely and tell people to use usbmon instead. The information isn't exactly the same but it's pretty close. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
