On Sat, Jul 07, 2012 at 11:01:53PM +0800, Lan Tianyu wrote: > On 2012/7/7 2:12, Greg KH wrote: > >On Fri, Jul 06, 2012 at 02:13:53PM +0800, Lan Tianyu wrote: > >>Change since v4: remove struct usb_port->udev member since it is not used. > >> > >>This patch is to make usb port a real device under usb hub interface. > >>Move port_owner to struct usb_port. > > > >As this adds sysfs files, this patch needs a Documentation/ABI update as > >well. > > > How about this? > > Documentation/ABI/testing/sysfs-bus-usb > > What: /sys/bus/usb/devices/.../(hub interface)/portX > Date: July 2012 > Contact Lan Tianyu <tianyu.lan@xxxxxxxxx> > Description: > The /sys/bus/usb/devices/.../(hub interface)/portX > is usb port device's sysfs direcotry. Yes, if this properly describes all the files in that directory. > >Also, one minor nit: > > > >>+ dev_err(hub->intfdev, "couldn't create port%d " > >>+ "device.\n", i + 1); > > > >Don't split strings across a line, it makes it impossible to search > >for. > > Is this Ok? keep line not more than 80 chars. > dev_err(hub->intfdev, > "couldn't create port%d device.\n", i + 1); Yes, that is fine. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
