Hello.
On 07/06/2012 06:24 PM, Vivek Gautam wrote:
> From: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx>
> This patch retrieves and configures the vbus control gpio via
> the device tree. The suspend/resume callbacks will be later
> modified for vbus control.
> Signed-off-by: Abhilash Kesavan <a.kesavan@xxxxxxxxxxx>
> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx>
> diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
> index 58b0409..8d5dc03 100644
> --- a/drivers/usb/host/ehci-s5p.c
> +++ b/drivers/usb/host/ehci-s5p.c
[...]
> @@ -64,6 +65,29 @@ static const struct hc_driver s5p_ehci_hc_driver = {
> .clear_tt_buffer_complete = ehci_clear_tt_buffer_complete,
> };
>
> +static int s5p_ehci_setup_gpio(struct platform_device *pdev)
> +{
> + int err = 0;
You don't need to initialize this...
> + int gpio;
> +
> + if (!pdev->dev.of_node)
> + return 0;
> +
> + gpio = of_get_named_gpio(pdev->dev.of_node,
> + "samsung,vbus-gpio", 0);
> + if (!gpio_is_valid(gpio))
> + return 0;
> +
> + err = gpio_request(gpio, "ehci_vbus_gpio");
Same comment about using gpio_request_one() instead as in previous mail...
> + if (err) {
> + dev_err(&pdev->dev, "can't request ehci vbus gpio %d", gpio);
> + return err;
> + }
> + gpio_set_value(gpio, 1);
> +
> + return err;
> +}
> +
> static u64 ehci_s5p_dma_mask = DMA_BIT_MASK(32);
>
> static int __devinit s5p_ehci_probe(struct platform_device *pdev)
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
