Re: [RFC 4/7] USB: Remove unused LPM variable.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 06, 2012 at 11:31:09AM -0400, Alan Stern wrote:
> On Thu, 5 Jul 2012, Sarah Sharp wrote:
> 
> > hub_initiated_lpm_disable_count is not used by any code, so remove it.
> > 
> > This commit should be backported to kernels as old as 3.5, that contain
> > the commit 8306095fd2c1100e8244c09bf560f97aca5a311d "USB: Disable USB
> > 3.0 LPM in critical sections."
> > 
> > Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > ---
> >  include/linux/usb.h |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/linux/usb.h b/include/linux/usb.h
> > index f717fbd..d24c114 100644
> > --- a/include/linux/usb.h
> > +++ b/include/linux/usb.h
> > @@ -556,7 +556,6 @@ struct usb_device {
> >  	struct usb3_lpm_parameters u1_params;
> >  	struct usb3_lpm_parameters u2_params;
> >  	unsigned lpm_disable_count;
> > -	unsigned hub_initiated_lpm_disable_count;
> >  };
> 
> You don't remove a corresponding kerneldoc entry for this field... 
> probably because no such entry exists!  Oh well, at least the end 
> result is okay.

Yep, hub_initiated_lpm_disable_count didn't have a kernel doc entry for
it.  I suspect its inclusion was a rebase mistake in the original patches.

Sarah sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux