On Thu, May 31, 2012 at 1:41 PM, Felipe Balbi <balbi@xxxxxx> wrote: > Hi, > > (please don't top-post, ever) hmm i missed that... thanks for pointing ;-) > > On Thu, May 31, 2012 at 12:06:21PM +0530, Rajaram R wrote: >> Hi Felipe/Paul >> >> Any reason for removing short_not_ok ? I believe it still holds true >> even after this patch. I will push a patch for the same if there is no >> objection. > > It doesn't hold true at all. We _want_ a short packet in order to end > the transfer. Let me illustrate: > > We want to receive 31-byte CBw, but our UDC can't handle short packets > on OUT direction, so we start a transfer for wMaxPacketSize. If we said > short_not_ok, the driver wouldn't like when we received 31-byte and > ended the transfer. IMO any tweak specific to a controller should be in the platform files.. In case of musb also the controller has some limitation and short packets are handled appropriately within the musb driver. In case of DWC, if there is a limitation you can always ignore this field. This field is being used by musb driver for managing DMA transfers. Removing it will affect musb drivers. Please clarify > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
