Re: [PATCH] USB: serial: Enforce USB driver and USB serial driver match

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bjørn Mork <bjorn@xxxxxxx> writes:

> I am not at all sure this is the correct way to fix this,
> but at least it solves my problem. 

Been sleeping on this, and I don't think the fix is entirely correct.

We may have situations where two or more drivers intentionally match the
same device, assuming the serial driver probe will sort out the correct
driver.  E.g. one driver doing wildcard pid matching for a single vid,
and another driver matching a single odd device from the same vendor.
The proposed patch will only allow one of those probes to run and will
therefore fail if the first called probe fails.

But I don't think we want to move the driver matching after the serial
driver probing either.  That would cause unnecessary probe calls from
the "wrong" drivers.

So search_serial_device needs to do the match.  Does anyone see a
problem with that?  I guess noone here does, unless I express it in code
:-)  So I'll go do that now.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux