Re: [PATCH] [g_mass_storage] Fix unmount problem with OS-X

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 25 May 2012, Pantelis Antoniou wrote:

> Hi Alan,
> 
> After performing all possible permutations it appears that I was wrong
> stating that g_mass_storage doesn't work with removable=n. I was trying to debug this 
> with a somewhat broken usb gadget driver and Mac OS X (at least 10.6.8) having a bug where in 
> many cases fails to mount the volume, whatever module parameter combination I use.
> 
> My apologies for the confusion I may have caused.

That's all right.  Multiple bugs can be pretty hard to diagnose.

> OTOH my opinion is that g_mass_storage with removable=y (which is the default)
> is broken for OS X, and this should either be documented, or the default should be changed
> to removable=n which is what the user expects.

I hadn't noticed that g_file_storage and g_mass_storage differ in their 
default values for "removable".  I agree, the default ought to be "n".

(On the other hand, the default _is_ documented -- but you have to look
at the source code to see it: lines 126-127 of
drivers/usb/gadget/f_mass_storage.c.)

The author of g_mass_storage ought to be able to explain the reason 
why the default was changed.  Perhaps he'll be willing to switch it 
back.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux