On Wed, May 23, 2012 at 04:00:56PM +0300, Alexander Shishkin wrote: > As reported by Dan Carpenter, there is a NULL check in udc_start() that > follows a dereference of the pointer that's being checked. However, at > that point udc pointer shouldn't ever be NULL and if it is, the dereference > should cause an oops. > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> looks good to my eyes: Acked-by: Felipe Balbi <balbi@xxxxxx> > --- > drivers/usb/chipidea/udc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c > index 51f9694..cdb9212 100644 > --- a/drivers/usb/chipidea/udc.c > +++ b/drivers/usb/chipidea/udc.c > @@ -1647,9 +1647,6 @@ static int udc_start(struct ci13xxx *udc) > struct device *dev = udc->dev; > int retval = 0; > > - if (!udc) > - return -EINVAL; > - > spin_lock_init(&udc->lock); > > udc->gadget.ops = &usb_gadget_ops; > -- > 1.7.10 > -- balbi
Attachment:
signature.asc
Description: Digital signature
