On Mon, May 21, 2012 at 05:23:54PM +0800, Richard Zhao wrote: > +static void __init imx6q_usb_init(void) > +{ > +#define HW_ANADIG_USB1_CHRG_DETECT 0x000001b0 > +#define HW_ANADIG_USB2_CHRG_DETECT 0x00000210 > + > +#define BM_ANADIG_USB_CHRG_DETECT_EN_B 0x00100000 > +#define BM_ANADIG_USB_CHRG_DETECT_CHK_CHRG_B 0x00080000 > + > + /* > + * The external charger detector needs to be disabled, > + * or the signal at DP will be poor > + */ > + Nit: drop this unnecessary new line. Regards, Shawn > + anatop_write_reg(NULL, HW_ANADIG_USB1_CHRG_DETECT, > + BM_ANADIG_USB_CHRG_DETECT_EN_B > + | BM_ANADIG_USB_CHRG_DETECT_CHK_CHRG_B, > + ~0); > + anatop_write_reg(NULL, HW_ANADIG_USB2_CHRG_DETECT, > + BM_ANADIG_USB_CHRG_DETECT_EN_B | > + BM_ANADIG_USB_CHRG_DETECT_CHK_CHRG_B, > + ~0); > +} > + -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html