On Sat, May 19, 2012 at 06:18:50AM +0000, Chen Peter-B29397 wrote: > > > > > > > > OK, now, I have understood you, do you think below are correct? > > > > > > - drivers/usb/otg renames to drivers/usb/phy > > > - Both USB PHY driver (PHY function supplier) and USB PHY User (like > > msm_otg.c, > > > fsl_otg.c, mv_otg.c, twl6030-usb.c) will be at drivers/usb/phy. > > > - msm_otg.c, fsl_otg.c mv_otg.c renames to msm_usb.c, fsl_usb.c, and > > mv_usb.c. > > > > these little guys don't seem to be using the PHY, they seem to *be* the > > PHY driver. See that msm_otg.c calls usb_set_transceiver(). That's a phy > > driver. Other than that, it's all good. > > > In fact, some like msm_otg.c, it implements PHY driver at msm_otg.c, and also use > this PHY driver at msm_otg.c. > > For some users, they may be confused why the drivers implements dual-role function > at the folder of drivers/usb/phy. I suggest we only move the pure PHY driver > like: ulpi.c, ulpi_viewpoint.c to drivers/usb/phy/ at usb-next tree currently. > > Or you think we just move all files (except otg_fsm.c and otg_fsm.h) > at drivers/usb/otg/ to drivers/usb/phy/ (at usd-next tree) now? That won't happen on v3.5 merge window anymore. Merge window is already open and these changes haven't been on linux-next for long enough. Let's take it easy, we can afford to miss v3.5 and discuss further until v3.6 ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
