Re: [PATCH 4/5] USB: gpio_vbus: a missing cancellation of workqueue in remove() function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, May 17, 2012 at 08:10:43PM +0900, Shinya Kuribayashi wrote:
> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@xxxxxxxxxxx>
> ---
>  drivers/usb/otg/gpio_vbus.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/otg/gpio_vbus.c b/drivers/usb/otg/gpio_vbus.c
> index 00e763e..1e6bd03 100644
> --- a/drivers/usb/otg/gpio_vbus.c
> +++ b/drivers/usb/otg/gpio_vbus.c
> @@ -348,6 +348,7 @@ static int __exit gpio_vbus_remove(struct platform_device *pdev)
>  	struct gpio_vbus_mach_info *pdata = pdev->dev.platform_data;
>  	int gpio = pdata->gpio_vbus;
>  
> +	cancel_delayed_work_sync(&gpio_vbus->work);

NAK, convert to threaded IRQ handler. Drop all that workqueue mess.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux