Hi, I'm not using this gpio_vbus driver myself, but preparing for a variant otg driver dedicated for our LSI with an internal transceiver, which is very similar to gpio_vbus. These four patches are what I noticed during my review for gpio_vbus, and tested using my variant driver. I don't think 4/4 is necessarily put into gpio_vbus, but it's just a nice-to-have feature IMHO. If you find it useful, just take it, thanks. Build tested on v3.0-based kernel, and rebased against the latest linus/master. Shinya Kuribayashi (4): USB: gpio_vbus: provide an appropriate debounce interval USB: gpio_vbus: fix inconsistent 'dev_id' parameters at free_irq() USB: gpio_vbus: put a missing regulator_put() on error USB: gpio_vbus: avoid consecutive vbus_session calls with the same "is_active" drivers/usb/otg/gpio_vbus.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) -- Shinya Kuribayashi Renesas Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html