On Thu, May 17, 2012 at 07:07:32PM +0200, Tilman Schmidt wrote: > Am 16.05.2012 23:55, schrieb Sarah Sharp: > > Set the disable_hub_initiated_lpm flag for for all USB communications > > drivers. I know there aren't currently any USB 3.0 devices that > > implement these class specifications, but we should be ready if they do. > > I follow the argument for class drivers. But this patch also > modifies drivers for specific existing USB 2.0 only devices > which are unlikely to ever grow USB 3.0 support, such as the > Gigaset ISDN driver: > > > drivers/isdn/gigaset/bas-gigaset.c | 1 + > > drivers/isdn/gigaset/usb-gigaset.c | 1 + Is there a particular reason why you think that driver is unlikely to ever get USB 3.0 support? I pretty much grabbed any USB driver that looked like a communications driver without looking too closely at the code. > What is the interest of setting the disable_hub_initiated_lpm > flag for these? It's partially to lay the foundation for anyone who wants to make a USB 3.0 communications driver in the future. They're likely to start from some USB 2.0 class driver, and copy a lot of code. If they notice that flag is set in all the USB communications class drivers, they're likely to set it as well. I'm not quite sure where the best place to provide documentation on the flag is. I've added the kernel doc comments to the structure, but maybe it needs to be documented somewhere in Documentation/usb/? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
