On Mon, 14 May 2012, Felipe Balbi wrote: > > + case PCI_VENDOR_ID_PHILIPS: > > + /* > > + * Philips controllers set HCC_PGM_FRAMELISTLEN, but > > + * they don't implement schedule sizes shorter than 1024. > > + */ > > + ehci->sched_size_bug = 1; > > } > > > > /* cache this readonly data; minimize chip reads */ > > Unrelated to $SUBJECT, but all those quirks could be passed through > driver_data from pci ID table. That will remove the need for the switch > statement. My 2 cents Many of them could, it's true. I don't know that it would be much of an improvement, though. The code would still have to test for most of the quirk flags because they require runtime checks (the one added by this patch is an exception). Also, which do you think would occupy less memory space: an array of pci_device_id structures or a switch statement jump table? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
