On Mon, May 14, 2012 at 01:28:11PM +0200, Marek Vasut wrote: > Dear Felipe Balbi, > > > On Fri, May 11, 2012 at 06:01:37AM +0000, Chen Peter-B29397 wrote: > > > > > Thanks for working on this, but it is just a PHY list, not the PHY > > > > > > > > layer > > > > > > > > > used by PHY driver and controller driver who wants to use PHY. > > > > > Besides, no USB Spec says there is relationship between OTG and USB > > > > > PHY. Heikki's (including mine) aim is separate PHY from OTG, and > > > > > create a generic PHY layer. A generic PHY layer is like below: > > > > > > > > > > - There is separate folder at drivers/usb/phy, which includes generic > > > > > > > > PHY > > > > > > > > > files and platform PHY drivers. > > > > > - Platform PHY driver will add itself to PHY list, and implement > > > > > kinds > > > > > > > > of > > > > > > > > > PHY utilities, like init, suspend, wakeup, charger detector, etc. > > > > > - The PHY user (controller driver, no only otg driver) will get the > > > > > PHY, and use it. > > > > > > > > Completely agree with you. But before we have the generic PHY layer, > > > > we got to have multi-phy support. It's needed for usb3 controller in > > > > OMAP5 where it needs usb2 phy and usb3 phy. > > > > > > I see. > > > > > > Felipe, would you give me some suggestion that my generic PHY work > > > should be on current tree or you think Kishon's patchset is ok, and I > > > should be based his work when it is in your usb tree? > > > > Kishon's patchset is a starting point. There are still many questions > > to be answered: how to we associate a PHY with a particular controller ? > > Maybe do it like the clock framework does? Just my 5 cents ... Maybe... but that'll, again, mean loads of per-board data to associate both devices. If everybody was using DT, we could just use phandles :-p Then again, when we want to have a kernel-wide generic PHY layer (not USB PHY layer, but generic), we will have waaaaay too much data to associate PHYs with their specific Links. -- balbi
Attachment:
signature.asc
Description: Digital signature
