From: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> Move spin_lock under the done label, so the lock will also be pulled in the error paths. Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> [rebased on top of the patchset] Signed-off-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> --- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 201379e..5cf7cd3 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -671,9 +671,9 @@ __acquires(udc->lock) if (udc->status == NULL) retval = -ENOMEM; +done: spin_lock(&udc->lock); - done: if (retval) dev_err(udc->dev, "error: %i\n", retval); } -- 1.7.10 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html