On Tue, May 08, 2012 at 11:29:03PM +0300, Alexander Shishkin wrote: > Currently, endpoints are initialized in gadget start/stop methods, however > for the new style gadgets it is expected that bind() can be called before > controller's start(), and we need endpoints already initialized at that > point. So, move endpoint initialization to controller's probe before we > switch to the "new style" gadget framework. > > Signed-off-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> After this patch, I get the following build warnings: CC [M] drivers/usb/gadget/ci13xxx_pci.o drivers/usb/gadget/ci13xxx_udc.c: In function ‘ci13xxx_start’: drivers/usb/gadget/ci13xxx_udc.c:2635:9: warning: unused variable ‘j’ [-Wunused-variable] drivers/usb/gadget/ci13xxx_udc.c:2635:6: warning: unused variable ‘i’ [-Wunused-variable] drivers/usb/gadget/ci13xxx_udc.c: In function ‘ci13xxx_stop’: drivers/usb/gadget/ci13xxx_udc.c:2710:16: warning: unused variable ‘i’ [-Wunused-variable] They better go away in a future patch, otherwise I'm going to be grumpy... Oh, and please always test each patch individually to prevent stuff like this from happening in the future. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
