Re: [PATCH v6.5 06/25] usb: gadget: ci13xxx: replace home-brewed logging with dev_{err,warn,info}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 08, 2012 at 11:29:02PM +0300, Alexander Shishkin wrote:
> Logging output in the driver is mostly done using custom err/warn/info
> macros which rely on the existence of the global variable _udc, which
> is a global reference to the udc controller structure. This reference
> will have to go in order to allow us to have more than one chipidea udc
> in the system.
> 
> Thus, replace custom macros with dev_{err,warn,info} using the platform
> device where possible. The trace() macro, which is a nop by default is
> left for tracing purposes.

No, that too should be removed, we have a kernel-wide tracing facility,
use that instead please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux