On Tue, Apr 24, 2012 at 10:16:31AM +0300, Alexander Shishkin wrote: > On Mon, 23 Apr 2012 16:07:37 +0200, Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> wrote: > > Call container_of after we have ensured that gadget is not NULL. > > Like Felipe says, the correct fix would be to drop the NULL > check. Again, I will include a fix for this in my rework patchset if you > don't mind. Feel free to do so. :) > It would probably make sense for us to join efforts on fixing this > driver somehow so that we don't end up fixing the same things, probably > I should create a tree for it somewhere with all the work that I'm doing > or what's would be the best/most convenient approach? Felipe, any > suggestions? As i mentioned in the other mail, those were some leftover patches from the beginning of this year. As i probably don't hit some more work with this usb core in the next weeks, we shall not run into conflicting or redundant work. Regards, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html