Hi Sergei, > > > - > > err_supplies: > > s3c_hsotg_phy_disable(hsotg); > > - > > regulator_bulk_free(ARRAY_SIZE(hsotg->supplies), > > hsotg->supplies); - > > - clk_disable_unprepare(hsotg->clk); > > - clk_put(hsotg->clk); > > - > > -err_regs: > > + err_irq: > > + free_irq(hsotg->irq, hsotg); > > + err_regs: > > Do not add spaces before labels. There's no spaces before > existing labels. Have you run the patch thru scripts/checkpatch.pl? Hmm, spaces have been added there. Unfortunately the checkpatch.pl script hasn't complaint about this. lukma@lmajewski:~/work/linux-usb(s3c-hsotg_devel_v5)$ cat 0001-usb-hsotg-samsung-err_irq-support-for-probe-function.patch | ./scripts/checkpatch.pl - total: 0 errors, 0 warnings, 34 lines checked Your patch has no obvious style problems and is ready for submission. Ok, I will remove those paces and resend this patch. Thanks for spotting :-) -- Best regards, Lukasz Majewski Samsung Poland R&D Center Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
