Re: [PATCH v5 18/18] usb:hsotg:samsung: err_irq: support for probe function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 20-04-2012 11:29, Lukasz Majewski wrote:

Missing handler for freeing requested IRQ added.
Moreover clk_ calls has been reorganized.

Signed-off-by: Lukasz Majewski<l.majewski@xxxxxxxxxxx>
Signed-off-by: Kyungmin Park<kyungmin.park@xxxxxxxxxxx>
---
  drivers/usb/gadget/s3c-hsotg.c |   13 +++++--------
  1 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index 1cac0be..c7e7050 100644
--- a/drivers/usb/gadget/s3c-hsotg.c
+++ b/drivers/usb/gadget/s3c-hsotg.c
@@ -3558,7 +3558,7 @@ static int __devinit s3c_hsotg_probe(struct platform_device *pdev)
  				 hsotg->supplies);
  	if (ret) {
  		dev_err(dev, "failed to request supplies: %d\n", ret);
-		goto err_supplies;
+		goto err_irq;
  	}

  	ret = regulator_bulk_enable(ARRAY_SIZE(hsotg->supplies),
@@ -3639,22 +3639,19 @@ static int __devinit s3c_hsotg_probe(struct platform_device *pdev)

  err_ep_mem:
  	kfree(eps);
-
 err_supplies:
  	s3c_hsotg_phy_disable(hsotg);
-
  	regulator_bulk_free(ARRAY_SIZE(hsotg->supplies), hsotg->supplies);
-
-	clk_disable_unprepare(hsotg->clk);
-	clk_put(hsotg->clk);
-
-err_regs:
+ err_irq:
+	free_irq(hsotg->irq, hsotg);
+ err_regs:

   Do not add spaces before labels. There's no spaces before existing labels.
Have you run the patch thru scripts/checkpatch.pl?

  	iounmap(hsotg->regs);

 err_regs_res:
 	release_resource(hsotg->regs_res);
 	kfree(hsotg->regs_res);
 err_clk:
+	clk_disable_unprepare(hsotg->clk);
 	clk_put(hsotg->clk);
  err_mem:
 	kfree(hsotg);

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux