A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Apr 18, 2012 at 11:42:27PM +0200, Adhir Ramjiawan wrote: > Hi Greg, > > Sorry for all the inconvenience. This is the very first time I have > submitted a kernel patch after much anticipation. I will use your > advice in future patches. > > The change in this patch was motivated by the checkpatch tool. If I > remember correctly, the line had a leading white space which I had > replaced with a tab space. Ok, but then you just created another coding style issue, the one where a line is larger than 80 columns, you forgot to run your patch through the checkpatch.pl tool :) Be a bit more careful next time. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
