Re: [PATCH] USB: serial: Fixed coding style errors in ti_usb_3410_5052.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

Sorry for all the inconvenience. This is the very first time I have
submitted a kernel patch after much anticipation. I will use your
advice in future patches.

The change in this patch was motivated by the checkpatch tool. If I
remember correctly, the line had a leading white space which I had
replaced with a tab space.

Many thanks

Adhir Ramjiawan

On Wed, Apr 18, 2012 at 10:59 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Apr 09, 2012 at 06:00:24PM +0200, Adhir Ramjiawan wrote:
> > Fixed 2 errors that had assignments in if statements and removed white
> > space characters from the start of a line.
>
> Don't mix different things in the same patch.  I applied your 2/2 patch
> that only did the if assignment fixes, but that means this patch doesn't
> apply.
>
> > Signed-off-by: Adhir Ramjiawan <adhirramjiawan0@xxxxxxxxx>
> > ---
> >  drivers/usb/serial/ti_usb_3410_5052.c |    8 +++++---
> >  1 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
> > index ab74123..b2a2395 100644
> > --- a/drivers/usb/serial/ti_usb_3410_5052.c
> > +++ b/drivers/usb/serial/ti_usb_3410_5052.c
> > @@ -298,7 +298,7 @@ MODULE_PARM_DESC(debug, "Enable debugging, 0=no, 1=yes");
> >
> >  module_param(closing_wait, int, S_IRUGO | S_IWUSR);
> >  MODULE_PARM_DESC(closing_wait,
> > -    "Maximum wait for data to drain in close, in .01 secs, default is 4000");
> > +             "Maximum wait for data to drain in close, in .01 secs, default is 4000");
>
> Why did you make this change?
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux