Re: Add dwc_otg driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



So, I looked into the Raspberry Pi kernel tree today, and I found this
as the very first patch (note, the tree is based on 3.1.x):

[full patch can be seen
https://github.com/raspberrypi/linux/commit/c2eaacd30565604bbf776ca6e83c9889ea87ea74
if you want it, I only show parts of the diffstat below for the sake of
the sanity of everyone involved]

On Tue, Jan 17, 2012 at 07:14:08PM +0000, popcornmix wrote:
> Signed-off-by: popcornmix <popcornmix@xxxxxxxxx>

First off, who really wrote this patch?  We really need to know that,
and you do as well if you are shipping this code (hint, you are...)
Please always provide proper authorship information, otherwise you might
find some lawyers breathing down your necks, trust me, I've been there,
it's not fun...

> ---
>  drivers/usb/Makefile                               |    1 +
>  drivers/usb/core/generic.c                         |    1 +
>  drivers/usb/core/hub.c                             |   52 +-
>  drivers/usb/core/message.c                         |   79 +
>  drivers/usb/core/otg_whitelist.h                   |  172 +-

This was scary, in that you are changing the core USB stack for your
debugging purposes, but hey, I can almost understand that.

But then things get wierd:

>  drivers/usb/host/dwc_common_port/Makefile          |   44 +
>  drivers/usb/host/dwc_common_port/Makefile.linux    |   36 +
>  drivers/usb/host/dwc_common_port/doc/doxygen.cfg   |  270 +
>  .../html/dir_c13d72e45af28cdc461a5f284d3d36fc.html |   81 +
>  .../usb/host/dwc_common_port/doc/html/dirs.html    |   22 +
>  .../usb/host/dwc_common_port/doc/html/doxygen.css  |  358 ++
>  .../host/dwc_common_port/doc/html/dwc__cc_8h.html  |  709 +++
>  .../dwc_common_port/doc/html/dwc__crypto_8c.html   |  435 ++
>  .../dwc_common_port/doc/html/dwc__crypto_8h.html   |  618 +++
>  .../host/dwc_common_port/doc/html/dwc__dh_8h.html  |  166 +
>  .../dwc_common_port/doc/html/dwc__list_8h.html     | 1844 +++++++
>  .../dwc_common_port/doc/html/dwc__modpow_8h.html   |   48 +
>  .../dwc_common_port/doc/html/dwc__notifier_8h.html |  306 ++
>  .../host/dwc_common_port/doc/html/dwc__os_8h.html  | 3090 +++++++++++

<zillions of html files deleted>

I thought I had seen it all, why are you adding HTML files to a
subdirectory of a kernel driver?  Why are you needing HTML files at all
in the first place?

Anyway, what's the status of getting this driver support merged into
mainline?

Felipe, I'm guesing this doesn't work with your dwc3 driver, right?  If
not, is anyone working on this?

Anyone know who I can poke about this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux