Hi, On Wed, Apr 11, 2012 at 06:49:41PM +0000, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:balbi@xxxxxx] > > Sent: Wednesday, April 11, 2012 6:44 AM > > > > This makes it far simpler to support host, > > otg and device roles properly. It also prevents > > a problem with dwc3 and host mode where we > > were requesting the entire memory region thus > > preventing xhci from ever ioremapping its own > > address space. > > > > Cc: Paul Zimmerman <Paul.Zimmerman@xxxxxxxxxxxx> > > Cc: Anton Tikhomirov <av.tikhomirov@xxxxxxxxxxx> > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > Hi Felipe, > > Adding Ido to the CC, he submitted a patch to add OTG support to > the driver. cool, thanks > Most of this patch seems to be concerned with splitting the global > register space from the device register space. Can you explain how > that helps with OTG and host mode? I don't see it. It seems like a > lot of churn for no good reason. Now that you said it, you're actually right. The only piece of the address space which needs to be splited out is the xHCI address space, otherwise xhci-hcd.ko won't be able to request_mem_region() for that area because we already did it on dwc3.ko. Will re-work this patch and send another version in a few hours. -- balbi
Attachment:
signature.asc
Description: Digital signature
