Re: usbrsa: dead lock usbrsa_write/usbrsa_write_room

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[ Please keep all reciepents in your replies. ]

On Tue, Mar 27, 2012 at 08:01:26PM +0000, tilman wrote:
> Hello Johan
>  
> > What kind of device are we talking about? And what speeds?
> usb-to-serial based on an AN2131Q (Eazy USB) and a ST16C550(UART).
> Speed is up to 460,8 kBaud

That's relatively slow. There should be no problem using the generic
implementation (which can handle high speeds as well).

> > You really should try to use the generic write before implementing your
> > own. 
> The generic write function works as well. I have not tested at high speeds
> though. The generic write function however has no way of knowing the current
> fill level of the tx buffer (EP3IN provides the available bytes in tx queue, and
> bytes received and stored into rx queue). And besides that, where is the
> challenge in using the generic  function ? :-)

Well, you shouldn't reinvent the wheel unless you have to. The generic
implementation is efficient and well-debugged. If you want (and need) to
take the fill-level information into account you should investigate
whether it's would be sufficient to hook into the generic implementation
before implementing from scratch.

Good luck,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux