Re: [RFC/PATCH] usb: host: xhci: don't re-enable IE constantly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Mar 16, 2012 at 02:03:58PM -0700, Sarah Sharp wrote:
> On Thu, Mar 15, 2012 at 04:37:08PM +0200, Felipe Balbi wrote:
> > while at that, define IMAN bitfield to aid
> > readability.
> > 
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > ---
> > 
> > Sarah, was there any reason to always enable IMAN_IP and IMAN_IE when Acking
> > the IRQ?
> 
> I can't remember if there was a reason.  Perhaps some host controllers
> don't actually set the interrupt enabled bit when we originally write
> it?  I think this was just a typo though.
> 
> > I'm concerned if this couldn't goof up some xHCI implementations, though I
> > haven't seend that happen.
> 
> Which hosts have you tested on?  I'll test on the ones I have and see if
> it causes any issues.

I tested with TI's and NEC's host cards.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux