Hi Greg, Am Donnerstag, den 15.03.2012, 12:34 -0700 schrieb GregKroah-Hartman: > On Thu, Mar 15, 2012 at 07:20:24PM +0100, Philipp Zabel wrote: > > This patch adds clk_prepare/clk_unprepare calls to the ohci-pxa27x > > driver by using the helper functions clk_prepare_enable and > > clk_disable_unprepare. > > Why use these instead of the existing clk_enable() calls? What does > this give us? > > greg k-h the clk API was split in two parts to allow some platforms to schedule in clk_prepare/clk_unprepare and still guarantee that clk_enable/clk_disable can be run in atomic contexts: 40d3e0f4942ec12c4521fe1b2a2b774164cd2c80 (clk: provide prepare/unprepare functions) clk_prepare/clk_unprepare are no-ops on PXA right now, but adding those calls is a prerequisite for switching to the common clock framework. clk_enable then only succeeds if clk_prepare was called before. best regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
