Forgot to CC maintainers. Done now. On 03/05/2012 02:51 PM, Jiri Slaby wrote: > This is a piece I missed the last time. > > Do not copy the functionality all over the tree. Instead, use the > helper the tty layer provides us with. > > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > --- > drivers/usb/class/cdc-acm.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c > index 6dcc3a3..b3fd449 100644 > --- a/drivers/usb/class/cdc-acm.c > +++ b/drivers/usb/class/cdc-acm.c > @@ -509,17 +509,12 @@ static int acm_tty_install(struct tty_driver *driver, struct tty_struct *tty) > if (!acm) > return -ENODEV; > > - retval = tty_init_termios(tty); > + retval = tty_standard_install(driver, tty); > if (retval) > goto error_init_termios; > > tty->driver_data = acm; > > - /* Final install (we use the default method) */ > - tty_driver_kref_get(driver); > - tty->count++; > - driver->ttys[tty->index] = tty; > - > return 0; > > error_init_termios: -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
