On Fri, 24 Feb 2012 12:09:13 +0200 Felipe Balbi <balbi@xxxxxx> wrote: > Hi, > > On Fri, Feb 24, 2012 at 09:25:03AM +0100, Lukasz Majewski wrote: > > On Fri, 10 Feb 2012 10:12:18 +0100 > > Lukasz Majewski <l.majewski@xxxxxxxxxxx> wrote: > > > > > Presented patch series fix several problems with S3C-HSOTG driver, > > > thus now the Multi Function Gadget (MFG) is working correctly. > > > > > > Those commits consist of EP0 transfer management fixes (ZLP > > > sending code and NAK management). > > > Moreover the disconnect irq handler has been removed. > > > > > > Code for recovering from device disconnection and connection > > > during ongoing transfer has been added as well. > > > > > > Patches done by Joonyoung Shim have been included to this patch > > > series, since those patches are necessary for further fixes. > > > Unfortunately they haven't been included to mainline yet. > > > > > > Tested with: > > > - DFU gadget (various size of the sent data - also packet = > > > MPS) > > > - Ethernet gadget (CDC and RNDIS) > > > - Multi Function Gadget (g_multi) > > > > > > HW: > > > - Samsung's C210 Universal rev.0 > > > > > > > > > Joonyoung Shim (2): > > > USB: s3c-hsotg: Add platform data callbacks for phy control > > > USB: s3c-hsotg: Add regulator support > > > > > > Lukasz Majewski (7): > > > USB: s3c-hsotg: NAK management for EP0 (Setup stage of control > > > transfers) > > > USB: s3c-hsotg: Sending ZLP packet for IN EP0 transfers > > > USB: s3c-hsotg: Increase number of available endpoints. > > > USB: s3c-hsotg: Extract core initialization function > > > USB: s3c-hsotg: Remove Disconnect Interrupt handler > > > USB: s3c-hsotg: Rename s3c_hsotg_disconnect function > > > USB: s3c-hsotg: Cable disconnection recovery code > > > > > > drivers/usb/gadget/s3c-hsotg.c | 580 > > > +++++++++++++++++++++------------------ 1 files changed, 312 > > > insertions(+), 268 deletions(-) > > > > > > --- > > > Dependences (required to be merged by samsung-soc kernel tree): > > > > > > http://comments.gmane.org/gmane.linux.usb.general/56341 > > > > > > > > > > Hi Felipe, > > > > I predict, that turning s3c-hsotg to dwc2 driver will take some > > time. Therefore I'd like to ask you for applying those fixes to > > s3c-hsotg driver. > > > > They are making the Samsung SoC's USB to work correctly, so until > > new driver emerges, we would like to use s3c-hsotg driver . > > Of course I can apply, just fix the comments I had on most patches and > resend the series and I can apply them. BTW, I plan to send pull > request to Greg on Monday (Tuesday at the latest) otherwise my > patches won't be in linux-next long enough to be merged. > Ok, I will try to do it ASAP. However, Tuesday is a good day for pull request :-) > > Question to other users of dwc2 controller. What in your opinion is > > an platform independent code (the code devoted to dwc2)? > > I can extract this code for Samsung's USB, but I'd like to hear > > other's opinion (as a reference I will also use the dwc_otg patch > > set). > > Take a look at the decisions we made on dwc3 driver, I guess it'll be > a good driver to base off of. In short, we have "abstracted" all the > platform-specific glue to a parent device/driver and just pass the > correct resources down to the core IP driver. > Ok, I will look into that. -- Best regards, Lukasz Majewski Samsung Poland R&D Center Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
