> -----Original Message----- > From: Felipe Balbi [mailto:balbi@xxxxxx] > Sent: Friday, February 24, 2012 6:15 PM > To: Eibach, Dirk > Cc: balbi@xxxxxx; Liu Shengzhou-B36685; linux-kernel@xxxxxxxxxxxxxxx; > gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > stern@xxxxxxxxxxxxxxxxxxx > Subject: Re: Commit 529febe breaks usb on Freescale P1022 > > Hi, > > On Fri, Feb 24, 2012 at 11:11:46AM +0100, Eibach, Dirk wrote: > > > > > > > > This commit introduces a check for the USB PHY clock. > > > > Problem is that CTRL_PHY_CLK_VALID bit seems not to be > > > present on all > > > > Freescale ehci implementations, at least P1022 does not have it. > > > > So this check always fails and the driver never gets loaded. > > > > > > hmm, you would need a revision check on that function then. > > > > Since I have no idea which Freescale platforms provide this bit and > > which platforms don't, I suggest withdrawing this commit and do some > > investigation on Freescales side to do this properly. > > Could be, but I would like to hear from Shengzhou first. Not sure what > Greg thinks though :-) > > -- > balbi Hello, Just now I checked it on P1022, P1022 does not have this bit. So far what I know as below: - P1023/P3041/P5020 have this bit, and mentions it in RM. - P3060/4080/PSC913x do have this bit, but not mentioned in RM. - P1022 have no this bit, not mention it in RM. I'm confirming this on more chips and will work out a new patch to fix it. Regards, Shengzhou -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
