RE: [PATCH 3/7 v2] usb: dwc3: add definitions for new registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Felipe Balbi [mailto:balbi@xxxxxx]
> Sent: Thursday, February 23, 2012 2:12 AM
> 
> Hi,
> 
> On Wed, Feb 15, 2012 at 06:56:58PM -0800, Paul Zimmerman wrote:
> > @@ -529,6 +579,14 @@ struct dwc3_request {
> >  	unsigned		queued:1;
> >  };
> >
> > +/*
> > + * struct dwc3_scratchpad_array - hibernation scratchpad array
> > + * (format defined by hw)
> > + */
> > +struct dwc3_scratchpad_array {
> > +	__le64	dma_adr[DWC3_MAX_HIBER_SCRATCHBUFS];
> 
> when abreviating "address" we generally use addr, can you make that
> change just to keep consistency ?

Sure, no problem.

> > +};
> > +
> >  /**
> >   * struct dwc3 - representation of our controller
> >   * @ctrl_req: usb control request which is used for ep0
> > @@ -607,8 +665,10 @@ struct dwc3 {
> >  #define DWC3_REVISION_180A	0x5533180a
> >  #define DWC3_REVISION_183A	0x5533183a
> >  #define DWC3_REVISION_185A	0x5533185a
> > +#define DWC3_REVISION_187A	0x5533187a
> >  #define DWC3_REVISION_188A	0x5533188a
> >  #define DWC3_REVISION_190A	0x5533190a
> > +#define DWC3_REVISION_194A	0x5533194a
> 
> do we already have other versions ?

Yes we do.

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux