Hi, On Wed, Feb 15, 2012 at 06:56:58PM -0800, Paul Zimmerman wrote: > @@ -529,6 +579,14 @@ struct dwc3_request { > unsigned queued:1; > }; > > +/* > + * struct dwc3_scratchpad_array - hibernation scratchpad array > + * (format defined by hw) > + */ > +struct dwc3_scratchpad_array { > + __le64 dma_adr[DWC3_MAX_HIBER_SCRATCHBUFS]; when abreviating "address" we generally use addr, can you make that change just to keep consistency ? > +}; > + > /** > * struct dwc3 - representation of our controller > * @ctrl_req: usb control request which is used for ep0 > @@ -607,8 +665,10 @@ struct dwc3 { > #define DWC3_REVISION_180A 0x5533180a > #define DWC3_REVISION_183A 0x5533183a > #define DWC3_REVISION_185A 0x5533185a > +#define DWC3_REVISION_187A 0x5533187a > #define DWC3_REVISION_188A 0x5533188a > #define DWC3_REVISION_190A 0x5533190a > +#define DWC3_REVISION_194A 0x5533194a do we already have other versions ? other than these two questions, looks great. -- balbi
Attachment:
signature.asc
Description: Digital signature