On Wed, Feb 22, 2012 at 07:03:55PM -0800, Sarah Sharp wrote: > On Wed, Feb 22, 2012 at 11:17:05AM +0800, Elric Fu wrote: > > 2012/2/22 Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>: > > > On Sat, Feb 18, 2012 at 01:32:27PM +0800, Elric Fu wrote: > > > Perfect, thanks! I'll send this off to Greg. The only thing you needed > > > was to Cc the stable mailing list. > > > > Thank you very much. I learn a lot of things from you. About Cc the > > stable mail list, I always thought I shouldn't cc stable and if the patch > > is done I should send the patch to maintainer then the maintainer will > > submit it to stable. It seems like a mistake. Do you mean I should cc > > the stable if the patch is done? > > Hmm, you should probably ask Greg about the stable mailing list and when > things get sent to it. Here's my understanding: > > You are correct that only the final patch should be sent to the stable > mailing list. That's sent automatically when Linus pulls a new > patch into his tree, but only if the stable mailing address is at the > end of the patch description. If someone forgets to put the Cc stable > line in the patch description, it's very likely to not make it into > stable. > > You can rely on the subsystem maintainer to add the stable CC line if > you wish. Not all of them are very good at sending things to stable > though, so you might want to do it yourself. > > If I have an RFC patch that I know will need to go into stable, I add > the Cc stable line in the description of the body. However, when I send > the RFC patch out, I make sure that it doesn't get sent to the stable > mailing list (this may require controlling what git send-email does). > When I send a pull request off to Greg, I don't send the mail off to the > stable list then either. > > I think that Greg's pull request to Linus also doesn't include the > stable mailing list, but I'm not sure. I think that only when the final > patch goes into Linus' tree does it get sent to the stable mailing list. The file, Documentation/stable_kernel_rules.txt describe how to properly submit a patch for inclusion in the stable kernel tree if you are interested. The only thing you really need to do is add the: Cc: stable <stable@xxxxxxxxxxxxxxx> to the signed-off-by: area of the patch, to get it included in a stable kernel release automatically. If you cc: the stable list when sending it to the usb list, to me, or anyone else, is not a big deal or needed, as when it hits Linus's tree is the most important thing. Just be sure that if you do copy the stable list, the cc: be in the proper place in the patch, not just in the email header, otherwise you will get an automated email from me pointing this problem out. I can't track patches by hand if they have gone into Linus's tree or not, so I rely on the automatic notification the signed-off-by area provides me, if a patch is copied to the list earlier is not a problem at all, I easily filter that away. Hope this helps, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
