On 02/22/2012 08:16 PM, Alan Stern wrote: > On Wed, 22 Feb 2012, Hauke Mehrtens wrote: > >> This EHCI/OHCI platform driver should replace the simple EHCI and OHCI >> platform drivers. It was developed to be used for the USB core of the >> Broadcom SoCs supported by ssb and bcma, but it should also work for >> other devices. >> >> Drivers like ehci-ath79.c, ehci-xls.c and ehci-ixp4xx.c should be >> relative easy be ported to this EHCI driver. >> And drivers like ohci-ath79.c, ohci-ppc-soc.c, ohci-sh.c and ohci-xls.c >> should be easy be ported to the this OHCI driver. >> >> I also thought about adding optional callbacks in the platform data >> struct called in some places like reset, to do device/platform specific >> operations, but later I thought it does not look nice. >> >> I am unable to test the suspend and resume part, as my SoC does not >> support this, but most of the platform driver do not support >> suspend/resume too. The code here should work, but was never runtime >> tested. >> >> After this patch is in the usb tree I will send the bcma and ssb driver >> using the generic driver from this patch again with some modifications. >> >> This is a new version of the patches send in >> http://thread.gmane.org/gmane.linux.ports.mips.general/33401/focus=84218 >> >> v2: >> * split include/linux/usb/hci_driver.h into include/linux >> /usb/ehci_pdriver.h and include/linux/usb/ohci_pdriver.h >> * remove flags from include/linux/usb/{e,o}ehci_pdriver.h >> * add kernel doc >> * add some more options into the structs to activate hardware quirks. > > This looks pretty good. Have you tested it with your ssb/bcma > hardware? > > Alan Stern > Yes I tested it on my ssb and bcma hardware. This hardware does not support suspend and resume, so I do not know if that is working it was just compile tested, but most platform devices do not have suspend/resume and it should work. If these patches get accepted I will send the patches for ssb and bcma support. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
