Re: [PATCH 1/3] usb/storage: a couple defines from drivers/usb/storage/transport.h to include/linux/usb/storage.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Michal Nazarewicz | 2012-01-13 22:13:54 [+0100]:

>>diff --git a/drivers/usb/gadget/storage_common.c b/drivers/usb/gadget/storage_common.c
>>index c7f291a..eb33fed 100644
>>--- a/drivers/usb/gadget/storage_common.c
>>+++ b/drivers/usb/gadget/storage_common.c
>>@@ -153,29 +153,10 @@
>>/* Bulk-only data structures */
>>-/* Command Block Wrapper */
>>-struct fsg_bulk_cb_wrap {
>>-	__le32	Signature;		/* Contains 'USBC' */
>>-	u32	Tag;			/* Unique per command id */
>>-	__le32	DataTransferLength;	/* Size of the data */
>>-	u8	Flags;			/* Direction in bit 7 */
>>-	u8	Lun;			/* LUN (normally 0) */
>>-	u8	Length;			/* Of the CDB, <= MAX_COMMAND_SIZE */
>>-	u8	CDB[16];		/* Command Data Block */
>>-};
>>-
>> #define USB_BULK_CB_WRAP_LEN	31
>> #define USB_BULK_CB_SIG		0x43425355	/* Spells out USBC */
>> #define USB_BULK_IN_FLAG	0x80
>
>Why aren't those lines removed?  What am I missing here?
>
>>-/* Command Status Wrapper */
>>-struct bulk_cs_wrap {
>>-	__le32	Signature;		/* Should = 'USBS' */
>>-	u32	Tag;			/* Same as original command */
>>-	__le32	Residue;		/* Amount not transferred */
>>-	u8	Status;			/* See below */
>>-};
>>-
>> #define USB_BULK_CS_WRAP_LEN	13
>> #define USB_BULK_CS_SIG		0x53425355	/* Spells out 'USBS' */
>> #define USB_STATUS_PASS		0
>
>Ditto.
>
>I've noticed that USB_STATUS_* macros have different names in storage.h,
>but the usage in mass/file storage can be changed to match the other name.

I just did that in an additional patch. So this patch remains as it, the
additional renames will happen in a follow-up patch.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux