Hi,
On Wed, Feb 15, 2012 at 06:19:39PM +0900, Anton Tikhomirov wrote:
> > > +static struct platform_driver dwc3_exynos_driver = {
> > > + .probe = dwc3_exynos_probe,
> > > + .remove = __devexit_p(dwc3_exynos_remove),
> > > + .driver = {
> > > + .name = "exynos-dwc3",
> >
> > should you add of_match_table here ? Not sure what are your plans to
> > support devicetree...
> >
>
> Currently we don't care about this.
fair enough.
> > > diff --git a/include/linux/platform_data/dwc3-exynos.h
> > b/include/linux/platform_data/dwc3-exynos.h
> > > new file mode 100644
> > > index 0000000..5eb7da9
> > > --- /dev/null
> > > +++ b/include/linux/platform_data/dwc3-exynos.h
> > > @@ -0,0 +1,24 @@
> > > +/**
> > > + * dwc3-exynos.h - Samsung EXYNOS DWC3 Specific Glue layer, header.
> > > + *
> > > + * Copyright (c) 2012 Samsung Electronics Co., Ltd.
> > > + * http://www.samsung.com
> > > + *
> > > + * Author: Anton Tikhomirov <av.tikhomirov@xxxxxxxxxxx>
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License as published by
> > > + * the Free Software Foundation; either version 2 of the License, or
> > > + * (at your option) any later version.
> > > + */
> > > +
> > > +#ifndef _DWC3_EXYNOS_H_
> > > +#define _DWC3_EXYNOS_H_
> > > +
> > > +struct dwc3_exynos_data {
> > > + int phy_type;
> > > + int (*phy_init)(struct platform_device *pdev, int type);
> > > + int (*phy_exit)(struct platform_device *pdev, int type);
> > > +};
> >
> > This is really my only comment to this patch. Why do you need to pass
> > phy_type down to driver if it's only gonna be passed back as an argument
> > to phy_init()/phy_exit() ??
> >
> > I would expect the PHY to know its own type, meaning that:
> >
> > pdata->phy_init(pdev);
> >
> > should be enough, no ?
> >
>
> I don't like this too, but it is only to comply with the current
> implementation
> of USB Phy setup in Exynos platform code (ref.
> arch/arm/mach-exynos/setup-usb-phy.c).
ok, I understand. So i'll apply as is. Thanks
--
balbi
Attachment:
signature.asc
Description: Digital signature
