Hi,
On Tue, Feb 14, 2012 at 06:45:41PM +0900, Kyungmin Park wrote:
> >> + while (1) {
> >> + u32 grstctl = readl(hsotg->regs + S3C_GRSTCTL);
> >> +
> >> + if (timeout-- < 0) {
> >> + dev_info(hsotg->dev,
> >> + "%s: reset failed, GRSTCTL=%08x\n",
> >> + __func__, grstctl);
> >> + return -ETIMEDOUT;
> >> + }
> >> +
> >> + if (!(grstctl & S3C_GRSTCTL_AHBIdle))
> >> + continue;
> >
> > is this a synopsys core ? Is this the DWC USB2 core ? If it is, how come
> > this was written as a samsung-only driver ? There's another company
> > which has been trying to merge a more generic DWC USB2 driver for almost
> > 2 years, when you guys could have joined the efforts and cleanup this
> > driver to allow more people to re-use it.
> Right, it's dwc2. We're monitored and worked on posted dwc2 drivers
> but it seems to hard to merge. we decided to use existing one for
> supporting it on exynos4 series.
> If dwc2 is supported at posted patches. we're welcome. we already did
> some works on it.
>
> BTW, which version do you mean? and plan to merge it at which kernel version?
> As I remember you mentioned remove the vendor specific codes and make
> it as dwc3. but there's no activities from original authors.
that's true, they have probably given up. But the fact that we already
have a dwc2 driver in-kernel remains :-)
We could just get this s3c-hsotg.c driver cleaned up and split out
samsung-specific details, and more people would be able to re-use what
you wrote ;-)
--
balbi
Attachment:
signature.asc
Description: Digital signature
