Re: [PATCH 9/9] USB:s3c-hsotg: Cable disconnection recovery code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 10, 2012 at 10:12:27AM +0100, Lukasz Majewski wrote:
> This code allows Samsung SoC's to recover its state when
> device is disconnected and connected during transfer.
> 
> It is necessary, in such a scenario, to reinitialize the USB core
> to assure correct initial state of the driver.
> 
> A simple mechanism with jiffies has been used to perform core reset
> only once.

I'm not sure a softreset is trully needed, unless there is a silicon
errata workaround going on here.

Please describe the problem further.

> Tested with:
> - DFU gadget (various size of the sent data - also packet = MPS)
> - Ethernet gadget (CDC and RNDIS)
> - Multi Function Gadget (g_multi)
> 
> HW:
> - Samsung's C210 Universal rev.0
> 
> Signed-off-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  drivers/usb/gadget/s3c-hsotg.c |   30 +++++++++++++++++++-----------
>  1 files changed, 19 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 02a3142..ad2ecce 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -144,7 +144,8 @@ struct s3c_hsotg_ep {
>   * @ep0_buff: Buffer for EP0 reply data, if needed.
>   * @ctrl_buff: Buffer for EP0 control requests.
>   * @ctrl_req: Request for EP0 control packets.
> - * @setup: NAK management for EP0 SETUP 
> + * @setup: NAK management for EP0 SETUP

the whitespace cleanup should be amended to the patch which introduced
NAK management.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux