Re: [PATCH 5/9] USB:s3c-hsotg: Increase number of available endpoints.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 10, 2012 at 10:12:23AM +0100, Lukasz Majewski wrote:
> S5PC110 and Exynos4 processors have up to 16 EPs (EP0 + 15),
> so allow HSOTG driver use them all.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  drivers/usb/gadget/s3c-hsotg.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 146636e..7664932 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -126,7 +126,7 @@ struct s3c_hsotg_ep {
>  	char			name[10];
>  };
>  
> -#define S3C_HSOTG_EPS	(8+1)	/* limit to 9 for the moment */
> +#define S3C_HSOTG_EPS	(15)	/* limit to 15 */

you should probably do a runtime revision check of this and change
accordingly.

What happens if a gadget driver tries to use all 16 endpoints on a
processor which has only 9 enpdoints ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux