On 2/14/12, Felipe Balbi <balbi@xxxxxx> wrote: > Hi, > > On Fri, Feb 10, 2012 at 10:12:19AM +0100, Lukasz Majewski wrote: >> From: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> >> >> The s3c-hsotg driver controls S3C64XX specific registers directly but >> this driver can be to EXYNOS also. This removes arch specific parts from > > what is this EXYNOS ? Last time I saw a patch for this controller it was > basically Synopsys DWC USB3 controller for which we already have a > driver under drivers/usb/dwc3/ Make it clear to know. S3C series, S5P series, Exynos4 series use dwc2. Exynos5 series use dwc3. So it's different USB controller. Exynos is brand name of samsung SoC. Thank you, Kyungmin Park > > If that's the case, you should try to use that driver, rather than > hacking this one. > >> Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> >> Signed-off-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx> >> --- >> drivers/usb/gadget/s3c-hsotg.c | 94 >> ++++++---------------------------------- >> 1 files changed, 14 insertions(+), 80 deletions(-) >> >> diff --git a/drivers/usb/gadget/s3c-hsotg.c >> b/drivers/usb/gadget/s3c-hsotg.c >> index 69295ba..6dab16a 100644 >> --- a/drivers/usb/gadget/s3c-hsotg.c >> +++ b/drivers/usb/gadget/s3c-hsotg.c >> @@ -35,9 +35,9 @@ >> >> #include <plat/regs-usb-hsotg-phy.h> >> #include <plat/regs-usb-hsotg.h> >> -#include <mach/regs-sys.h> >> #include <plat/udc-hs.h> >> #include <plat/cpu.h> >> +#include <plat/usb-phy.h> > > while at that, can you also move your platform_data to > <linux/platform_data/s3c-hsotg.h> and try to drop the arch dependency ? > > -- > balbi > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
