Re: [PATCH] usb:gadget:rndis:fix Missing req->context assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi,

On Fri, Feb 10, 2012 at 09:54:51AM +0100, Lukasz Majewski wrote:
> It is crucial to assign each req->context value to struct rndis.
> 
> The problem happens for multi function gadget (g_multi) when multiple
> functions are calling common usb_composite_dev control request.
> 
> It might happen that *_setup method from one usb function will
> alter some fields of this common request issued by other USB
> function.

this is a bit weird, why would a function change a request which isn't
supposed to handled by it ? I mean, functions need to check the ctrl
request to be sure they should be handling it.

Your patch shouldn't be necessary, really, because the context is
initialized when the request is allocated.

what happens exactly ? Who changes the context field and why ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux