On Tue, Feb 14, 2012 at 12:51 AM, Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> wrote: > The xHCI 0.96 spec says that HS bulk and control endpoint NAK rate must > be encoded as an exponent of two number of microframes. The endpoint > descriptor has the NAK rate encoded in number of microframes. We were > just copying the value from the endpoint descriptor into the endpoint > context interval field, which was not correct. This lead to the VIA > host rejecting the add of a bulk OUT endpoint from any USB 2.0 mass > storage device. > > The fix is to use the correct encoding. Refactor the code to convert > number of frames to an exponential number of microframes, and make sure > we convert the number of microframes in HS bulk and control endpoints to > an exponent. > > Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> > Reported-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> > Suggested-by: Andiry Xu <andiry.xu@xxxxxxx> > --- > > Hi Felipe, > > Can you test this bug fix and see if it makes USB 2.0 mass storage > devices work under your VIA host? Send me the dmesg if it doesn't. Nope, still doesn't work. I tested this on 3.2, should I use some 3.3 rc? Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
