On Thu, 09 Feb 2012 12:58:53 +0100, Chris Kelly <ckelly@xxxxxxxxxxxxxxx> wrote:
I am a completely new to this newsgroup and have a rather basic question. I wish to submit a new driver to the staging area and the patch file is rather large (>200K). Is the correct way to submit this to break it down into a number of patches with a few files in each rather than a single large patch. If so what is the recommended maximum size for each patch file.
You should break patches into pieces that make sense on its own. This often (but not always) means not on file-boundary. For instance, if you add some functionality to existing subsystems, you might want to split it to separate patch. If your driver has many functionalities, you might want to split them into several patches so that the first patch implements only the basic ones, next one adds something, and so on. If there is no way to to spilt the patch into such logical changes, you'll probably have to send it as a single patch. But you should try to split it as in the end it benefits you since there will be more people willing to look at set of smaller patches (as small patches are easier to review) then a single large patch. Then again, if that's a driver for some relatively unique hardware, it is likely that not so many people will be able to review it anyway. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
