Re: [PATCH v3] usb/dummy_hcd: allow to free requests on disabled endpoints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 04, 2012 at 05:01:37PM +0100, Sebastian Andrzej Siewior wrote:
> * Sergei Shtylyov | 2012-01-28 19:12:56 [+0400]:
> 
> >On 27-01-2012 23:41, Sebastian Andrzej Siewior wrote:
> >
> >>diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
> >>index 4141b27..ba845b3 100644
> >>--- a/drivers/usb/gadget/dummy_hcd.c
> >>+++ b/drivers/usb/gadget/dummy_hcd.c
> >>@@ -596,14 +596,12 @@ static struct usb_request *dummy_alloc_request(struct usb_ep *_ep,
> >>
> >>  static void dummy_free_request(struct usb_ep *_ep, struct usb_request *_req)
> >>  {
> >>-	struct dummy_ep		*ep;
> >>  	struct dummy_request	*req;
> >>
> >>-	if (!_ep || !_req)
> >>-		return;
> >>-	ep = usb_ep_to_dummy_ep(_ep);
> >>-	if (!ep->desc&&  _ep->name != ep0name)
> >>+	if (!_ep || !_req) {
> >>+		WARN_ON(!_ep || !_req);
> >
> >   __WARN()?
> 
> Okay

Are we having another version of this ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux