On Mittwoch, 8. Februar 2012, Oliver Neukum wrote: > Am Mittwoch, 8. Februar 2012, 22:10:44 schrieb Danny Kukawka: > > Set addr_assign_type correctly to NET_ADDR_RANDOM in case > > a random MAC address was generated and assigned to the netdevice. > > > > Signed-off-by: Danny Kukawka <danny.kukawka@xxxxxxxxx> > > --- > > drivers/net/usb/usbnet.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > > index fae0fbd..7bd07d7 100644 > > --- a/drivers/net/usb/usbnet.c > > +++ b/drivers/net/usb/usbnet.c > > @@ -1365,6 +1365,7 @@ usbnet_probe (struct usb_interface *udev, const > > struct usb_device_id *prod) dev->net = net; > > strcpy (net->name, "usb%d"); > > memcpy (net->dev_addr, node_id, sizeof node_id); > > + net->addr_assign_type |= NET_ADDR_RANDOM; > > > > /* rx and tx sides can use different message sizes; > > * bind() should set rx_urb_size in that case. > > Don't you set the flag too early here? By that time we don't know > whether the device provides a real MAC, do we? You're right. Maybe it's the wrong place. Better the drivers take care of setting the correct addr_assign_type. Danny -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
