hi, On Mon, Feb 06, 2012 at 06:55:26PM +0300, Sergei Shtylyov wrote: > Hello. > > On 02/06/2012 05:26 PM, Felipe Balbi wrote: > > >Those transfer types are generally high bandwidth, so we > >want to optimize transfers with those endpoints. > > >For that, databook suggests allocating 3 * wMaxPacketSize > >of FIFO. Let's do that. > > >Signed-off-by: Felipe Balbi<balbi@xxxxxx> > >--- > > >This will be sent to v3.4 merge window, unless someone > >has any concerns. > > > drivers/usb/dwc3/gadget.c | 20 ++++++++++++++++++-- > > 1 files changed, 18 insertions(+), 2 deletions(-) > > >diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > >index 1f64e7c..0542b96 100644 > >--- a/drivers/usb/dwc3/gadget.c > >+++ b/drivers/usb/dwc3/gadget.c > [...] > >@@ -180,11 +181,26 @@ int dwc3_gadget_resize_tx_fifos(struct dwc3 *dwc) > > if (!(dep->flags& DWC3_EP_ENABLED)) > > continue; > > > >- tmp = dep->endpoint.maxpacket; > >- tmp += mdwidth; > >+ if (usb_endpoint_xfer_bulk(dep->desc) > >+ || usb_endpoint_xfer_isoc(dep->desc)) > >+ mult = 3; > >+ > >+ /* > >+ * REVISIT: the following assumes we will always enough space > ^ "have" missing? > > >+ * available on the FIFO RAM for all possible usecases. Make > > Use cases. My spellchecker protests otherwise. :-) will fix, thanks -- balbi
Attachment:
signature.asc
Description: Digital signature
