On Fri, Feb 03, 2012 at 08:38:10PM +0000, Russell King - ARM Linux wrote: > On Fri, Feb 03, 2012 at 12:32:28PM -0800, Greg KH wrote: > > On Fri, Feb 03, 2012 at 08:09:12PM +0000, Russell King - ARM Linux wrote: > > > Clean up the ohci-sa1111 driver formatting to be more compliant with > > > current standards, and add 'static' to various function definitions > > > to avoid sparse complaints about undeclared functions. Remove the > > > unnecessary local declaration of 'usb_disabled', which can be found > > > instead in linux/usb.h. > > > > > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx> > > > > Do you want me to take these 5 patches through the USB tree? Or are you > > going to take them through an ARM tree? > > I forgot to send the introduction to linux-usb, so you've probably missed > the comment that they depend on some previous patches. Yeah, I missed that :) If these depend on other patches, feel free to take them in your tree then. > > Either is fine with me, if ARM, feel free to add: > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > to them. > > There was one question mark I had over a patch - that was the addition > of the .reset method in the hc_driver for sa1111 stuff. This seems to > only get called once during initial driver bring-up. Comments I found > in the code suggest that it was used more often in the past. Is that > something that's going away? I don't think so, but Alan (on linux-usb@) would be the best to answer that one. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
