Re: [PATCH v3] usb: cdc-wdm: cannot wait forever for blocking read/write on reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Donnerstag, 2. Februar 2012, 11:34:23 schrieb Bjørn Mork:
> @@ -523,7 +535,7 @@ static int wdm_open(struct inode *inode, struct file *file)
>                 goto out;
>  
>         desc = usb_get_intfdata(intf);
> -       if (test_bit(WDM_DISCONNECTING, &desc->flags))
> +       if (test_bit(WDM_DISCONNECTING, &desc->flags) || test_bit(WDM_RESETTING, &desc->flags))
>                 goto out;
>         file->private_data = desc;
>  

No, you are misusing the flags here. We need a way to have mutual exclusion.
The flags may be set after we have passed that point of execution.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux