> -----Original Message----- > From: Pavan Kondeti [mailto:pkondeti@xxxxxxxxxxxxxx] > Sent: Wednesday, February 01, 2012 6:11 PM > To: Liu Shengzhou-B36685 > Cc: linux-usb@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH] powerpc/usb: fix issue of CPU halt when missing > USB PHY clock > > On 2/1/2012 2:50 PM, Shengzhou Liu wrote: > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci- > fsl.c > > index b556a72..834237e 100644 > > --- a/drivers/usb/host/ehci-fsl.c > > +++ b/drivers/usb/host/ehci-fsl.c > > @@ -239,7 +239,7 @@ static void ehci_fsl_setup_phy(struct ehci_hcd > *ehci, > > ehci_writel(ehci, portsc, &ehci->regs->port_status[port_offset]); > > } > > > > -static void ehci_fsl_usb_setup(struct ehci_hcd *ehci) > > +static int ehci_fsl_usb_setup(struct ehci_hcd *ehci) > > { > > struct usb_hcd *hcd = ehci_to_hcd(ehci); > > struct fsl_usb2_platform_data *pdata; @@ -299,12 +299,19 @@ > static > > void ehci_fsl_usb_setup(struct ehci_hcd *ehci) #endif > > out_be32(non_ehci + FSL_SOC_USB_SICTRL, 0x00000001); > > } > > + > > + if (!(in_be32(non_ehci + FSL_SOC_USB_CTRL) & CTRL_PHY_CLK_VALID)) > { > > + printk(KERN_WARNING "fsl-ehci: USB PHY clock invalid\n"); > > + return -1; > > Please return a proper error code. -ENODEV ? [Shengzhou] Ok, updated in v2, thanks. > > > + } > > + return 0; > > } > > > -- > Sent by a consultant of the Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
